#TXT WRITE DECIMALS PYTHON CODE#
#TXT WRITE DECIMALS PYTHON TRIAL#

Help='The file to read the hexadecimal values from') Parser = argparse.ArgumentParser(description='Describe program here') '''Read the given input file and convert each hexadecimal value The final product import argparseĭef write_and_print_result(args, result): Placing this in a function of its own also prevents you from opening the file continuously. This can be done as described in the following question: with open(input_file) as input_file: Right now the program reads all the text in the file into memory. Reading the file should also be done line by line as an iterator, to prevent huge files from crashing your program by too high memory consumption. We could just check if the line starts with 0x (e.g. Assuming only the hexadecimal values should be on a line, it becomes a lot simpler though. One would be to use regex on the current line of the file to find any hexadecimal values. The last ValueError can be solved in a number of ways. Print('Input file does not exist, please try again') This one is quite easy to solve: before opening the file, check if it exists using the already imported os module: if not os.path.exists(args): Hex2dec2.py: error: the following arguments are required: input_file

#TXT WRITE DECIMALS PYTHON CODE#

When we run the above code without any arguments, we get the following: usage: hex2dec2.py input_file This means that if the file is imported as a module, this will not run. The if _name_ = '_main_': part of the code is only applicable if it's run as a script. Help='The file to read the hexadecimal values from'Īt this point you can access the command line arguments args as a dictionary. Parser.add_argument('input_file', type=str, Parser = argparse.ArgumentParser(description='Describe what your program does') I personally use argparse, since it's pretty simple and it's part of the standard library. This can be solved by using a CLI module such as argparse, click, or perhaps another one you like. The first error to solve would be the ValueError of not giving a filename as argument when running the program. The above errors tells us we need some error checking. ValueError: invalid literal for int() with base 0: 'random word' If a file was given which exists but has an invalid hexadecimal value in it (for instance a random string), the program also crashes: Traceback (most recent call last): Running it with an invalid file, or no arguments at all, crashes the program with either a FileNotFoundError or ValueError respectively. The program ran as expected with a correct file, and produced an output file with the converted values. Python 2 also supports the print() function, so it should have no issue running on Python 2 as well. Changing the print statements to functions fixed this issue.

Since it's using a built in function without any other operation, is the function necessary?Īs said above, using Python 3 failed to run it.

This means you could also return result immediately: return int(hex, 0)

You're storing the result in a variable and then returning the variable without doing anything else to it.

In this case it's not too big of a deal though.

Rather than hex2dec, perhaps use hex_to_decimal.

Some other things about the above function: '''Convert a hexadecimal string to a decimal number''' For instance in the hex2dec function: def hex2dec(hex): I have no idea what the bug is, and what the answer from StackOverflow was. Some comments however don't add any value for future reading: #this took me a few hour to figure out a bug. For example, print 'converted =' + str(converted) is invalid syntax in Python 3, use print() instead (as a function). The script currently does not work in Python 3. However, may I ask you what would you do to enhance this further? and if you could suggest, could anyone suggest me which topic or area I can study further to improve this code or any other about Python? #this to print the result for reference on-screen.Įven though this is done but I feel there are plenty area I could improve to this script e.g. #this took me a few hour to figure out a bug.

#this to make sure the output generate as a new file with _1 #this to accept parameter from command-line #this is the main function to convert hexadecimal to decimal The code is follow #this was copied from Learn Python the Hard way exercise.

#TXT WRITE DECIMALS PYTHON TRIAL#

#this is content from hex.txtĪnd this is what I expected my python to deliver output #this is content from hex_1.txtĪfter 3 hour of trial and error. I made a small script to read text file that contain hexadecimal and convert to another file in decimal by using command-line as a filename input.

Txt write decimals python